Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate from Intel to Apple Silicon CI #1540

Merged
merged 2 commits into from
Jan 2, 2024
Merged

Migrate from Intel to Apple Silicon CI #1540

merged 2 commits into from
Jan 2, 2024

Conversation

spencertransier
Copy link
Contributor

@spencertransier spencertransier commented Dec 27, 2023 •
edited
Loading

This PR migrates Simplenote iOS from Intel to Apple Silicon CI.

The "Build and Test" step succeeded, which builds the app and runs the unit tests: https://buildkite.com/automattic/simplenote-ios-apple-silicon/builds/3. The "UI Test (Full)" step fails due to a known issue with the test accounts that are used in the UI tests: #1536 (comment)

I ran the UI tests locally on my Apple Silicon Mac and 37 out of 43 passed. The six that failed don't appear to be due to any Intel vs. Apple Silicon difference, so I don't think they should be a blocker to this migration.

Accompanying buildkite-ci PR to update the Terraform config: https://github.com/Automattic/buildkite-ci/pull/338

@spencertransier spencertransier added the tooling Related to anything that supports the building & maintaining of the project. label Dec 27, 2023
@spencertransier spencertransier requested a review from a team December 27, 2023 23:36
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Dec 27, 2023 •
edited
Loading

You can test the changes in simplenote-ios from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr1540-4d9326e-018cadd6-2a17-4a5f-a7f8-7a9958fce82c on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@spencertransier spencertransier marked this pull request as ready for review December 28, 2023 01:37
@peril-automattic
Copy link

Warnings
⚠️ PR is not assigned to a milestone.

Generated by 🚫 dangerJS

AliSoftware
AliSoftware approved these changes Jan 1, 2024
View reviewed changes
Copy link
Contributor

@AliSoftware AliSoftware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happily surprised that there were no changes needed in the codebase to migrate SN from Xcode 14.3 to Xcode 15.1, especially given the app is not really maintained anymore those days! 🎉

@AliSoftware
Copy link
Contributor

AliSoftware commented Jan 1, 2024 •
edited
Loading

PS: CI is red because the config was apparently reverted to unclustered in Buildkite (probably via a terraform apply from an unrelated buildkite-ci PR) and the last build was thus run on Intel infra, where xcode-15.1 does not exist. So this is not surprising.

@spencertransier Once you apply https://github.com/Automattic/buildkite-ci/pull/338 (which I just approved) to deploy the changes, I'd suggest you to rebuild the last commit to validate that the changes were taken into account

  • I think you can just do this using the "Rebuild" button in Buildkite… but that being said, I'm not 100% sure that this won't reuse the settings of the build it is rebuilding (instead of re-evaluating the updated pipeline settings, like the cluster to use)
  • So, alternatively you might have to push an empty commit (git commit --allow-empty -m"Empty commit to retrigger CI" && git push) instead.

@spencertransier spencertransier merged commit 6465e28 into trunk Jan 2, 2024
4 of 8 checks passed
@spencertransier spencertransier deleted the use/apple-silicon-ci branch January 2, 2024 18:12
@crazytonyli crazytonyli mentioned this pull request Jan 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AliSoftware AliSoftware AliSoftware approved these changes

Assignees
No one assigned
Labels
tooling Related to anything that supports the building & maintaining of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@spencertransier @wpmobilebot @AliSoftware